Make WarpSpecializePartitionsOp implement RegionBranchInterface #8799
+31
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing IR traversals for things like dataflow analysis cannot automatically descend into the non-default partitions of a WarpSpecializeOp because we do not encode the edges to these regions through RegionBranchInterface. Changing the warpspec operations to reflect these edges allows us to clean up code in the dataflow analyses that walks the IR looking for `WarpSpecializePartitionsOp`, and populates its block args.
Contributor
Author
|
cc @Mogball this is a follow-up to your suggestion on #8723. I wanted to see if the desired behaviour could just fall out of setting up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing IR traversals for things like dataflow analysis cannot automatically descend into the non-default partitions of a WarpSpecializeOp because we do not encode the edges to these regions through RegionBranchInterface.
Changing the warpspec operations to reflect these edges allows us to clean up code in the dataflow analyses that walks the IR looking for
WarpSpecializePartitionsOp, and populates its block args.