Add custom button support #60
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey @kritikhedau, thank you for the PR 🙌 Would you mind opening a fresh PR with your changes against the latest develop branch? This one looks like it has pulled in a bunch of other changes. It would also be great to update the docs with these changes and perhaps add an example. Cheers! |
Contributor
Author
|
Hey @troberts-28, thanks for the feedback! 🙌
I’ve created a new PR based on the latest develop branch and included the
requested updates — docs and an example as well.
Here’s the new PR: #63
Appreciate your guidance!
…On Sun, 19 Oct 2025 at 20:33, Tim Roberts ***@***.***> wrote:
*troberts-28* left a comment (troberts-28/react-native-timer-picker#60)
<#60 (comment)>
Hey @kritikhedau <https://github.com/kritikhedau>, thank you for the PR 🙌
Would you mind opening a fresh PR with your changes against the latest
develop branch? This one looks like it has pulled in a bunch of other
changes. It would also be great to update the docs with these changes and
perhaps add an example.
Cheers!
—
Reply to this email directly, view it on GitHub
<#60 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASCIPOM2I23773I4GEXCRQ33YOR4RAVCNFSM6AAAAACJTEA7HOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMJZG4ZTGMJTGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Owner
|
Thanks @kritikhedau! Will take a look 🤓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive support for custom buttons in the TimerPickerModal component, allowing developers to fully customize the modal's action area with their own button components, additional buttons, or completely custom layouts.