added a (crashing) test that calls an ffi-function from a callback #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tromey
reviewed
Jan 2, 2018
| (ert-deftest ffi-call-callback-with-ffi-add-call () | ||
| (let* ((cif (ffi--prep-cif :int [:int])) | ||
| (pointer-to-callback (ffi-make-closure cif #'callback-with-ffi-add-call))) | ||
| (should (eq (test-call-callback pointer-to-callback) "hello")))) |
Owner
There was a problem hiding this comment.
Something is strange here, because test-call-callback is going to return an integer, but this test is checking to see if it is eq to a string -- which can't happen.
When I change this to expect 23, it works locally.
I wouldn't doubt that there is a problem -- that issue you pointed at has never been fixed -- but I think some other test case is required to show it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into this problem (when building a libclang-based emacs plugin): when calling a function from a callback, the (global) environment pointer is nulled out after the function call (but before finishing the callback). This causes an assertion to fail and crashes emacs.
I see that this is tricky to handle due to the poorly designed emacs runtime (see aaptel/emacs-dynamic-module#41). I have some ideas how to fix/hack it (e.g., a map of function calls to environment objects) and would be willing to help. I felt that this starts with contributing a test case :-).