Skip to content

Fix errcheck / gopls nits in main.go #4416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix errcheck / gopls nits in main.go #4416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,9 @@ func run(state overseer.State) {
if *githubScanToken != "" {
// NOTE: this kludge is here to do an authenticated shallow commit
// TODO: refactor to better pass credentials
os.Setenv("GITHUB_TOKEN", *githubScanToken)
if err := os.Setenv("GITHUB_TOKEN", *githubScanToken); err != nil {
logFatal(err, "error setting github token in environment")
}
}

// When setting a base commit, chunks must be scanned in order.
Expand Down Expand Up @@ -1063,7 +1065,7 @@ func runSingleScan(ctx context.Context, cmd string, cfg engine.Config) (metrics,
for _, ref := range refs {
if errs := ref.Snapshot().Errors; len(errs) > 0 {
errMsgs := make([]string, len(errs))
for i := 0; i < len(errs); i++ {
for i := range len(errs) {
errMsgs[i] = errs[i].Error()
}
ctx.Logger().Error(nil, "encountered errors during scan",
Expand Down Expand Up @@ -1121,7 +1123,7 @@ func logFatalFunc(logger logr.Logger) func(error, string, ...any) {
func commaSeparatedToSlice(s []string) []string {
var result []string
for _, items := range s {
for _, item := range strings.Split(items, ",") {
for item := range strings.SplitSeq(items, ",") {
item = strings.TrimSpace(item)
if item == "" {
continue
Expand Down