Update api.js and docker-compose.yml #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix error when using local storage, the app does not append the SCREENSHOTS_DIR variable when reading screenshot file but does so when writing.
Merge 2 "volumes" tag due to Docker disregarding the former.
Fixing an incomplete fix regarding local image storage file path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue when using local storage for screenshot and reading the image: the app doesn't append SCREENSHOTS_DIR to the image path, resulting in a 404.
Fixed issue in docker compose definition: there were 2 "volumes" tag, docker disregarded the first one and only mounts volumes in the second tag.