Skip to content

Conversation

@Quanta-Naut
Copy link
Contributor

@Quanta-Naut Quanta-Naut commented Nov 5, 2025

fixes #409

@seveibar I think I fixed the issue, please do check it out.

I have also attached a demo video below for your reference, please do let me know for any improvements to be made, and also I am sorry in advance if this isn't the the right fix. Thanks.

@vercel
Copy link

vercel bot commented Nov 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
pcb-viewer Ready Ready Preview Comment Nov 5, 2025 2:05pm

@Quanta-Naut
Copy link
Contributor Author

Recording.2025-11-05.193046.mp4

@Quanta-Naut
Copy link
Contributor Author

@seveibar @imrishabh18 please review it. Thanks.

/**
* Calculates the bounding box for all components within a PCB group
*/
const calculateGroupBoundingBox = (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc there must be some utility in core or in math-utils to get the boundings, use that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, I will explore the repos you mentioned and try implementing it. Thanks.

@imrishabh18
Copy link
Member

imrishabh18 commented Nov 5, 2025

Recording.2025-11-05.193046.mp4

The vertical Y line should be touching the center of the smtpads, I guess. Otherwise, it gets a bit difficult to understand

@Quanta-Naut
Copy link
Contributor Author

Recording.2025-11-05.193046.mp4

The vertical Y line should be touching the center of the smtpads, I guess. Otherwise, it gets a bit difficult to understand

Yeah I was confused whether to consider center of smt pads or center of components, sure I will change it to smtpad's center.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Draw the position offset when hovering over a component

2 participants