-
Notifications
You must be signed in to change notification settings - Fork 40
feat: added show offset of components from anchor on hover #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Recording.2025-11-05.193046.mp4 |
|
@seveibar @imrishabh18 please review it. Thanks. |
| /** | ||
| * Calculates the bounding box for all components within a PCB group | ||
| */ | ||
| const calculateGroupBoundingBox = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iirc there must be some utility in core or in math-utils to get the boundings, use that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I will explore the repos you mentioned and try implementing it. Thanks.
The vertical Y line should be touching the center of the smtpads, I guess. Otherwise, it gets a bit difficult to understand |
Yeah I was confused whether to consider center of smt pads or center of components, sure I will change it to smtpad's center. |
fixes #409
@seveibar I think I fixed the issue, please do check it out.
I have also attached a demo video below for your reference, please do let me know for any improvements to be made, and also I am sorry in advance if this isn't the the right fix. Thanks.