Fix types: make validateOnly optional also in alterConfigs()
#1718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cj-christoph-gysin
changed the title
validateOnly optional also in alterConfigs()
cj-christoph-gysin
force-pushed
the
types
branch
from
d205c2b to
4d25fa6
Compare
cj-christoph-gysin
force-pushed
the
types
branch
from
4d25fa6 to
283930a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validateOnlydefauilts tofalseincreateTopic(),createPartitions()andalterConfigs(), but the types for the latter make it required.This PR fixes types to reflect the code correctly.
Documented here:
kafkajs/src/admin/index.js
Line 672 in 55b0b41
Setting the default to false here:
kafkajs/src/admin/index.js
Line 744 in 55b0b41