docs: update debugging & tips text #270
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megstang
reviewed
May 18, 2023
|
|
||
| ### Debugging | ||
| If you haven't already, run the tests now. You should see some failing tests. Work through fixing the code until the tests pass. You only change the application code, not the tests. It might be helpful to run each test one at a time and fix one by one. | ||
| If you haven't already, run the tests now. You should see some failing tests. Work through fixing the code until the tests pass. You will only change the application code in `spec/dmv_spec.rb`, not the tests. You will make updates to the tests in `spec/dmv_data_service_spec.rb`, not the application code. It might be helpful to run each test one at a time and fix one by one. |
There was a problem hiding this comment.
"You will only change the application code in spec/dmv_spec.rb, not the tests." is a bit contradictory. dmv_spec is a test, not application code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend Curriculum PR Template
Description
This PR updates the Iteration 1 documentation under
debugging & tipsto inform students what to expect when running the tests and how they should proceed.Provide a brief summary of the change(s) included in this pull request
debuggingsection in Iteration 1 to be more explicit for what student expectations are.tipssection in Iteration 1 to be more explicit for what the student expectations are.Why are we making this update?
Share the reason(s) for this pull request
Type of update
How will we measure the success of this change?
Share any hypothesized outcomes we might observe
What questions do you have/what do you want feedback on? (optional)
List any specific questions and feedback requests