Use let-blocks when apprioriate in stdlib & examples #2051
Conversation
yannham
force-pushed
the
task/use-let-blocks
branch
from
4b35e7f to
a93c6d9
Compare
|
Bencher Report| Branch | 2051/merge |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| fibonacci 10 | 📈 view plot | 499,030.00 |
| foldl arrays 50 | 📈 view plot | 1,763,600.00 |
| foldl arrays 500 | 📈 view plot | 6,846,300.00 |
| foldr strings 50 | 📈 view plot | 7,102,700.00 |
| foldr strings 500 | 📈 view plot | 62,544,000.00 |
| generate normal 250 | 📈 view plot | 44,564,000.00 |
| generate normal 50 | 📈 view plot | 2,063,800.00 |
| generate normal unchecked 1000 | 📈 view plot | 3,395,000.00 |
| generate normal unchecked 200 | 📈 view plot | 749,760.00 |
| pidigits 100 | 📈 view plot | 3,209,000.00 |
| pipe normal 20 | 📈 view plot | 1,495,900.00 |
| pipe normal 200 | 📈 view plot | 10,055,000.00 |
| product 30 | 📈 view plot | 823,410.00 |
| scalar 10 | 📈 view plot | 1,504,700.00 |
| sum 30 | 📈 view plot | 819,460.00 |
|
This is actually also blocked on tweag/topiary#747 to be able to update to latest Topiary in the flake. |
|
Now that we've got rid of Topiary as an input of the Nickel flake, we need Topiary to be compatible with tree-sitter 0.22 (used by the Nickel grammar) - which is the case, but this version hasn't been released yet. Waiting for a new version of Topiary to be released, so that we can finally format let-blocks. |
|
(while this PR is by no mean really required for 1.9, its precondition is: update Topiary to latest version once it's on crates.io so that |
yannham
force-pushed
the
task/use-let-blocks
branch
from
a93c6d9 to
ed9bdf2
Compare
This PR updates to Topiary 0.5.1, which includes the support for formatting let-blocks (and the let-in formatting fix). Additionally, I made a pass on the examples and the stdlib to use let-blocks whenever it seemed appropriate, so that both remains idiomatic Nickel.
This is the last item on the checklist before being able to release Nickel 1.9