Skip to content

Conversation

@Xophmeister
Copy link
Member

@Xophmeister Xophmeister commented Sep 18, 2025

CSS formatting fixes

Resolves #1083
Resolves #1084
CC @lavigneer

Description

CSS fixes:

  • Comments after declarations
  • Identifiers that include special characters

Checklist

Checklist before merging, wherever relevant:

  • CHANGELOG.md updated
  • Documentation (The Topiary Book, README.md, etc.) up-to-date
  • Updated regression tests

@Xophmeister Xophmeister marked this pull request as ready for review September 18, 2025 13:44
@Xophmeister Xophmeister requested a review from a team September 18, 2025 13:44
@Xophmeister Xophmeister force-pushed the chris/fix/css branch 2 times, most recently from 897e4cd to 77ae8b3 Compare September 18, 2025 14:04
@toastal
Copy link
Contributor

toastal commented Sep 18, 2025

.Foo {
  background: cornsilk;
  /* My loooooooooooooooooooong comment */
  color: firebrick;
}

should not output

.Foo {
  background: cornsilk; /* My loooooooooooooooooooong comment */
  color: firebrick;
}

now the comments are always cuddled which isn’t good either. Is leave it alone not an option?

Even worse is

.Foo {
  /* My loooooooooooooooooooong comment 
  */
  background: cornsilk;
  /* My loooooooooooooooooooong comment */
  color: firebrick;
}

Now outputs

.Foo {
  /* My loooooooooooooooooooong comment 
  */background: cornsilk; /* My loooooooooooooooooooong comment */
  color: firebrick;
}

@Xophmeister
Copy link
Member Author

Thanks, @toastal: I think I've got all those cases (and then some) covered in 7701291

@toastal
Copy link
Contributor

toastal commented Sep 18, 2025

appears better

Copy link
Member

@mkatychev mkatychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSS indentifiers not identified correctly CSS newline after comments in property list

3 participants