generated from tweag/project
-
Notifications
You must be signed in to change notification settings - Fork 46
CSS formatting fixes #1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
CSS formatting fixes #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #1084
8d7ccd1 to
b270c5e
Compare
897e4cd to
77ae8b3
Compare
77ae8b3 to
712030b
Compare
.Foo {
background: cornsilk;
/* My loooooooooooooooooooong comment */
color: firebrick;
}should not output .Foo {
background: cornsilk; /* My loooooooooooooooooooong comment */
color: firebrick;
}now the comments are always cuddled which isn’t good either. Is leave it alone not an option? Even worse is .Foo {
/* My loooooooooooooooooooong comment
*/
background: cornsilk;
/* My loooooooooooooooooooong comment */
color: firebrick;
}Now outputs .Foo {
/* My loooooooooooooooooooong comment
*/background: cornsilk; /* My loooooooooooooooooooong comment */
color: firebrick;
} |
|
appears better |
62ba3eb to
d11a1b6
Compare
mkatychev
approved these changes
Sep 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS formatting fixes
Resolves #1083
Resolves #1084
CC @lavigneer
Description
CSS fixes:
Checklist
Checklist before merging, wherever relevant:
CHANGELOG.mdupdatedREADME.md, etc.) up-to-date