Fix Azure adapter listFiles ignoring numFiles parameter
#79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thanks for the library!
We're just trying to integrate it within our org and have stumbled upon the issue that Azure
listFilesdoes not use thenumFilesargument so I went ahead and filled in the blanks.Used this doc as reference: https://learn.microsoft.com/en-us/javascript/api/%40azure/storage-blob/containerclient?view=azure-node-latest#@azure-storage-blob-containerclient-listblobsflat (MS has some terrible docs btw, yikes).
The default page size for listing blobs seems to be
5000assuming the SDK works the same as the REST API: https://learn.microsoft.com/en-us/rest/api/storageservices/list-blobs?tabs=microsoft-entra-idHaven't tested this code yet.
By the way, is it intended that
numFilesis implicitly is set to10000inAbstractAdapter? I think it would make sense to add this information to thelistFilesdocs.