Add support for multi nested inheritance of the same parent#196
Open
jbrey wants to merge 1 commit intotwitter:masterfrom
Open
Add support for multi nested inheritance of the same parent#196jbrey wants to merge 1 commit intotwitter:masterfrom
jbrey wants to merge 1 commit intotwitter:masterfrom
Conversation
Collaborator
|
Thanks for the patch and tests. This might take a while... I'll need to confer with other mustache implementors. |
|
up |
|
jbrey seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This request provides the support for nesting the same parent and redefining the parents section several times in the same template.
This allows for instance to reuse a template which defines a container with a content region and nest the containers.
Example:
Will render:
Basically the compiler associates the nested level to the subs’ code in the generated objects and the template takes into account this level to decide which sub should be used.
This adds also compliance with java implementation that does not fail on these use cases.
I add also three tests in order to demonstrate and test the behavior.
I am using the same template on both server side and ui side, that’s why I need to have this working on both sides.
JB