TracedHandler should use an existing Local[F, Span[F]] #591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a Lambda with an initialization
Resourcethat (simplified) looks like this:When I went to use
TracedHandler.apply, I noticed that it was constructing its ownIOLocalto hold the trace state. I don't think that will be in sync with thegiven Local[IO, Span[IO]] <- IO.local(Span.noop[IO])built in the resource, and I want them to be in sync because I want theClient[F]to have the same trace state as the rest of the handler, so I think we need a new way to build aTracedHandlerthat can inherit the ambientLocal[F, Span[F]].I started off by adding this as a separate
TracedHandler.localmethod, but I didn't think that was a particularly good name, so I ended up basically replacingTracedHandler.apply(in a binary-compatible way).