SAM Type Interface #920

Jay-Lokhande · 2025-06-18T18:26:10Z

This PR's objective is to create a SAM type interface in log4cats

core/shared/src/main/scala/org/typelevel/log4cats/JsonLike.scala

morgen-peschke · 2025-06-19T23:38:21Z

core/shared/src/main/scala/org/typelevel/log4cats/KernelLogLevel.scala

+final case class KernelLogLevel(name: String, value: Double) {
+  def namePadded: String = KernelLogLevel.padded(this)
+
+  KernelLogLevel.add(this)
+}


issue (structure): I'm sick right now, but we should get on a call towards the end of next week and go over bincompat.

Case classes are wonderful for applications, but we're going to tend to avoid them because they don't play nicely with bincompat.

agreed 💯

core/shared/src/main/scala/org/typelevel/log4cats/KernelLogLevel.scala

morgen-peschke · 2025-06-20T00:36:10Z

core/shared/src/main/scala/org/typelevel/log4cats/LoggerKernel.scala

+  final def logTrace(record: Log.Builder => Log.Builder): F[Unit] =
+    log(KernelLogLevel.Trace, record)
+  final def logDebug(record: Log.Builder => Log.Builder): F[Unit] =
+    log(KernelLogLevel.Debug, record)
+  final def logInfo(record: Log.Builder => Log.Builder): F[Unit] =
+    log(KernelLogLevel.Info, record)
+  final def logWarn(record: Log.Builder => Log.Builder): F[Unit] =
+    log(KernelLogLevel.Warn, record)
+  final def logError(record: Log.Builder => Log.Builder): F[Unit] =
+    log(KernelLogLevel.Error, record)


suggestion (naming): If we do end up needing these, we should simplify down the names

Suggested change

final def logTrace(record: Log.Builder => Log.Builder): F[Unit] =

log(KernelLogLevel.Trace, record)

final def logDebug(record: Log.Builder => Log.Builder): F[Unit] =

log(KernelLogLevel.Debug, record)

final def logInfo(record: Log.Builder => Log.Builder): F[Unit] =

log(KernelLogLevel.Info, record)

final def logWarn(record: Log.Builder => Log.Builder): F[Unit] =

log(KernelLogLevel.Warn, record)

final def logError(record: Log.Builder => Log.Builder): F[Unit] =

log(KernelLogLevel.Error, record)

final def trace(record: Log.Builder => Log.Builder): F[Unit] =

log(KernelLogLevel.Trace, record)

final def debug(record: Log.Builder => Log.Builder): F[Unit] =

log(KernelLogLevel.Debug, record)

final def info(record: Log.Builder => Log.Builder): F[Unit] =

log(KernelLogLevel.Info, record)

final def warn(record: Log.Builder => Log.Builder): F[Unit] =

log(KernelLogLevel.Warn, record)

final def error(record: Log.Builder => Log.Builder): F[Unit] =

log(KernelLogLevel.Error, record)

lets keep it until final change, I tried to change as suggested but its giving error due to duplicates

js-console/src/main/scala/org/typelevel/log4cats/console/ConsoleLogger.scala

core/shared/src/main/scala/org/typelevel/log4cats/Log.scala

Jay-Lokhande · 2025-06-20T13:15:50Z

Thank you for all the suggestions, I will rework on it

… Logger

core/shared/src/main/scala/org/typelevel/log4cats/KernelLogLevel.scala

morgen-peschke · 2025-09-28T14:46:23Z

core/shared/src/test/scala/org/typelevel/log4cats/NoOpLoggerKernelTest.scala

+    // All of these should be no-ops and not throw
+    logger.info("This should not appear").void *>
+      logger.error("This should not appear").void *>
+      logger.warn("This should not appear").void *>


cleanup: logger.warn and friends already return F[Unit], so you don't need to add .void

morgen-peschke · 2025-09-28T14:47:51Z

core/shared/src/test/scala/org/typelevel/log4cats/SamLoggerTest.scala

+import cats.effect.IO
+import munit.CatsEffectSuite
+
+class SamLoggerTest extends CatsEffectSuite {


issue: tests that require you to inspect the console to see if they pass or not aren't automated tests.

They can be useful when doing exploratory programming, but they shouldn't generally be committed to source.

morgen-peschke · 2025-09-28T14:49:02Z

core/shared/src/test/scala/org/typelevel/log4cats/SamStructuredLoggerTest.scala

+  test("SamStructuredLogger should handle context with multiple entries") {
+    var capturedLogs: List[(KernelLogLevel, Log.Builder[String] => Log.Builder[String])] = Nil
+
+    val testKernel = new LoggerKernel[IO, String] {


issue: Instead of inlining this with a var, it'd be better to rework the existing test loggers to use LoggerKernel

…khande/log4cats into feature/log4cats-sam-type

Jay-Lokhande · 2025-11-17T06:41:29Z

@morgen-peschke just a gentle reminder regarding the PR review whenever you get a chance. I understand things can get busy thank you for your time and help!

morgen-peschke · 2025-11-18T01:17:22Z

build.sbt

+      // Removed implicit conversions for monad transformers from Logger - these were intentionally removed
+      ProblemFilters
+        .exclude[DirectMissingMethodProblem]("org.typelevel.log4cats.Logger.kleisliLogger"),
+      ProblemFilters
+        .exclude[DirectMissingMethodProblem]("org.typelevel.log4cats.Logger.eitherTLogger"),
+      ProblemFilters
+        .exclude[DirectMissingMethodProblem]("org.typelevel.log4cats.Logger.optionTLogger"),
+      // Removed implicit conversions for monad transformers from LoggerFactory - these were intentionally removed
+      ProblemFilters
+        .exclude[DirectMissingMethodProblem]("org.typelevel.log4cats.LoggerFactory.kleisliFactory"),
+      ProblemFilters
+        .exclude[DirectMissingMethodProblem]("org.typelevel.log4cats.LoggerFactory.eitherTFactory"),
+      ProblemFilters
+        .exclude[DirectMissingMethodProblem]("org.typelevel.log4cats.LoggerFactory.optionTFactory"),


Intentionally removed or not, filtering them out doesn't fix the bin-compat issues, so we should restore these methods.

morgen-peschke · 2025-11-18T01:37:46Z

build.sbt

+      // Added new kernel methods - these are new API additions
+      ProblemFilters.exclude[ReversedMissingMethodProblem]("org.typelevel.log4cats.Logger.kernel"),
+      ProblemFilters.exclude[ReversedMissingMethodProblem](
+        "org.typelevel.log4cats.extras.DeferredLogger.kernel"
+      ),
+      ProblemFilters.exclude[ReversedMissingMethodProblem](
+        "org.typelevel.log4cats.extras.DeferredSelfAwareStructuredLogger.kernel"
+      ),
+      ProblemFilters.exclude[ReversedMissingMethodProblem](
+        "org.typelevel.log4cats.extras.DeferredStructuredLogger.kernel"
+      )


Bumping tlBaseVersion will tell MiMa that you're going to do a minor version bump, and these will go away.

ThisBuild / tlBaseVersion := "2.8"

Jay-Lokhande added 12 commits June 18, 2025 15:50

Added Logger Kernel Initial File

485b98b

sbt scalafmt

8d8223f

added withMethodName method

f6e9d55

added more SAM type specific files

e7f0be4

changed LogLevel to remove conflict

7f6dc0e

going back to LogLevel name

9c3c243

original WriterTLogger

9908c00

deleted DefferedLogLevel

4fb2850

build.sbt

fc58670

scalafmt

23b2094

sbt scalafmtSbt

3f1f34c

added KernelLogLevel

7961c15

morgen-peschke reviewed Jun 20, 2025

View reviewed changes

iRevive mentioned this pull request Jun 20, 2025

Logs module typelevel/otel4s#994

Closed

15 tasks

add new samlogger interface based on old and poc logger

a5708c3

Jay-Lokhande added 7 commits June 23, 2025 07:15

add SamStructuredLogger that delegates to LoggerKernel, with original…

649468d

… Logger

modify log with parameterized with the context type

ac5aaee

change datatype double to int and use cats Order

53dda4f

update LoggerKernel to use new Log.scala

634de7d

update LogRecord and Recordable to use paramerterized Log

b7f0d10

update ConsoleLogger to original, JsonLike

859753b

remove unused Context.Encoder

ac1a39b

lenguyenthanh mentioned this pull request Jun 30, 2025

Allow adding effect's contextual environment to the log context #800

Open

morgen-peschke reviewed Jul 9, 2025

View reviewed changes

core/shared/src/main/scala/org/typelevel/log4cats/KernelLogLevel.scala Outdated Show resolved Hide resolved

Jay-Lokhande and others added 5 commits August 7, 2025 18:09

Merge branch 'typelevel:main' into feature/log4cats-sam-type

3beb5f7

remove JsonLike Structure instead bypass it direct

44ab02b

modify files to adapt new change

10b0c81

update log.scala

4b746e2

update recordable

2ad479c

morgen-peschke reviewed Sep 28, 2025

View reviewed changes

Jay-Lokhande and others added 23 commits October 4, 2025 06:57

remove LogRecord Recordable and SamLoggerAdapter

bd68364

update core's extras

d19ffae

update old interfaces with logger kernel functionality

749fd3d

remove SamLoggerAdaptorTest

72376e8

update sam implementation after removing LogRecor and Recordable

b0ddff1

update test suite

58f2b51

update js-console ConsoleLogger

b606c3b

update slf4j Logger Internel

6962ff8

update testing module with LoggerKernel

041375c

update NoOp Logger

468114f

Merge branch 'typelevel:main' into feature/log4cats-sam-type

cb28f49

Merge branch 'feature/log4cats-sam-type' of https://github.com/Jay-Lo…

f695de3

…khande/log4cats into feature/log4cats-sam-type

fix match level error

f6bf9a3

fix match error

329bc40

fix match error

a32d908

fir test errors

809e560

try differentt fix

1b7aeb9

fix tests

2a9fe26

sbt scala format

3a13966

update mima Binary issues

0f8c152

add MiMa Exclusions

21b3e6c

remove sourcecode

e69b27d

remove java.util time class as suggested

8bbf794

Jay-Lokhande requested a review from morgen-peschke October 20, 2025 04:28

morgen-peschke reviewed Nov 18, 2025

View reviewed changes

SAM Type Interface #920

Are you sure you want to change the base?

SAM Type Interface #920

Uh oh!

Conversation

Jay-Lokhande commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Jay-Lokhande commented Jun 20, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jay-Lokhande commented Nov 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Jay-Lokhande commented Jun 18, 2025 •

edited

Loading