feat: configurable batching and rate-limiting for typesense imports #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• add buffer_size_limit and flush_interval_seconds parameters to typesensehelper • replace immediate record import with buffered approach • flush records based on buffer size or time interval thresholds • update all test instances with new constructor parameters
• add buffer_size_limit and flush_interval_seconds to configloader • support environment variables for batching configuration • add validation rules for batching parameters • create test suites for batching parameter validation • update main index to use config values instead of hardcoded values • add example batching configuration to typesense_docs.json
tharropoulos
force-pushed
the
batching-rate-limitting
branch
from
0c416b8 to
87c2aaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
• implement record batching with buffer size and time-based flush triggers
• add
buffer_size_limitandflush_interval_secondsconfig parameters• support environment variables
TYPESENSE_BUFFER_SIZE_LIMITandTYPESENSE_FLUSH_INTERVAL_SECONDS• add validation rules ensuring parameters are positive integers
• update typesensehelper constructor to accept batching parameters
• replace immediate record import with buffered approach for better performance
• add example configuration to typesense_docs.json
• update documentation with batching configuration options
performance impact: reduces api calls to typesense by batching records instead of sending them immediately in small chunks
PR Checklist