fix: add missing page parameter for union search pagination #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perfect! What's the timeline for getting this merged in and tagged? 😊 |
jasonbosco
requested changes
Jul 15, 2025
- set commonParams.page from first search request when union is configured - add pagination tests for union search with multi-index result merging - ensure different results are shown when navigating between pages
tharropoulos
force-pushed
the
union-pagination
branch
from
1b5a544 to
052783c
Compare
|
@jasonbosco It didn't have to do with changes to this PR. Have since rebased master here, so it now passes the tests |
jasonbosco
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix #253
PR Checklist