V28 changes #39
Merged
V28 changes #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `Stemming`, `StemmingDictionaries` and `StemmingDictionary` classes - Add `stemming` attribute to `Client` class - Add integration tests for dictionary operations - Update `collections_spec.rb` with stem dictionary field
- replace single-quoted `\n` with double-quoted `"\n"` in `jsonl` string processing - fix inconsistent line splitting behavior in `upsert` method
jasonbosco
requested changes
Feb 5, 2025
- add fallback response for empty dictionary retrieval in `StemmingDictionaries` - refactor test setup to ensure proper test isolation - fix webmock configuration in tests
Resolved through fb2029f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
Adds support for stemming for v28, updates the
upload-artifactaction version to v4 in CI and changes the Ruby version matrix to include3.3and remove2.7.Change Summary
Stemming Functionality:
lib/typesense.rb: Added requires fortypesense/stemming,typesense/stemming_dictionaries, andtypesense/stemming_dictionary.lib/typesense/client.rb: Addedstemmingattribute and initialized it in theClientclass.lib/typesense/stemming.rb: Introduced theStemmingclass with a method to retrieve stemming dictionaries.lib/typesense/stemming_dictionaries.rb: Introduced theStemmingDictionariesclass with methods to upsert and retrieve dictionaries.lib/typesense/stemming_dictionary.rb: Introduced theStemmingDictionaryclass with methods to retrieve a specific dictionary.Test Suite Updates:
spec/typesense/collections_spec.rb: Addedstem_dictionaryattribute to various test cases.spec/typesense/stemming_spec.rb: Added a new test suite for stemming dictionaries with tests for upserting, retrieving a specific dictionary, and retrieving all dictionaries.CI Workflow Update:
.github/workflows/tests.yml: Updatedactions/upload-artifactfrom version 3 to version 4.3.0, 3.2, 3.3and remove2.7from the matrix altogether.PR Checklist