-
Notifications
You must be signed in to change notification settings - Fork 9
Get tests, build files, and workflows working #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ntf functions of benchmarks
…er.h and used include only in advance query c file
…hub.com/ubco-db/EmbedDB into 150-fix-the-test_sort-failing-unit-test
Makefile Ubuntu Unit Test Results 1 files 17 suites 0s ⏱️ Results for commit 175aaf0. ♻️ This comment has been updated with latest results. |
PlatformIO Ubuntu Unit Test Results 1 files 102 suites 18s ⏱️ Results for commit 175aaf0. ♻️ This comment has been updated with latest results. |
rlawrenc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review completed by tracing through code together
Description
This PR addresses the failing tests, workflows, and makefiles. There were numerous changes that were made to fix these issues.
What was changed
Linting
Most of the changes and deletions in the diff are not actual changes to the code or functionality, but most of the .c and .h code was not formatted recently with clang, and so linting all the .c and .h files is where most of that comes from. Of actual changes to code there's may 200-300 insertions/deletions.
Python Tests
Makefile
Benchmarks
Sort Test
Sort Wrapper
Workflow
setcommand in powershell does not hold that value for the duration of the script, meaning it would always run the example db file and not the benchmarks. It would work withexporton ubuntu, but not windows. The workflow now just has an extra job, one for ubuntu and one for windows, with the env syntax being set to work on windows. It does add more jobs to the workflow and makes the file a bit longer, but I think this should be fine.