Refactor: Remove unnecessary Foundation imports #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sidepelican
requested changes
Nov 25, 2025
Sources/Mockolo/Executor.swift
Outdated
| // | ||
|
|
||
| import Foundation | ||
| import Foundation.NSFileManager |
Collaborator
There was a problem hiding this comment.
This is overdone, please revert it (including other similar parts)
sidepelican
approved these changes
Nov 25, 2025
Collaborator
sidepelican
left a comment
sidepelican
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
sidepelican
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request addresses a dependency incompatibility issue and improves codebase quality by performing a general cleanup of module imports.
1. Code Cleanup: Removing Redundant Imports
Redundant
import Foundationstatements have been removed from several files across the codebase where the module was not strictly required (i.e., the files only use types and functionality available in the Swift Standard Library).Rationale:
This practice adheres to Swift style guides, helps clarify module dependencies, and promotes a cleaner codebase.
Verification
The project successfully builds, and all existing unit and integration tests have been run and passed after applying these changes.