Skip to content

do LayoutUpdate for menus with no entries #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

do LayoutUpdate for menus with no entries #548

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6c49e3
update and open menu if there's no entries
lost-melody Sep 12, 2024
fb1b312
Revert "update and open menu if there's no entries"
lost-melody May 8, 2025
df9e8a1
handle LayoutUpdated signal for empty menus
lost-melody May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions dbusMenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,16 +475,23 @@ export const DBusClient = GObject.registerClass({
}
}

_isEmptyMenu() {
const rootItem = this.getRoot();
return !rootItem || rootItem.getChildren().length === 0;
}

_onSignal(_sender, signal, params) {
// an empty menu will not open, thus the signal "open-state-changed"
// will never be emitted, and thus `this._active` will always be false.
if (signal === 'LayoutUpdated') {
if (!this._active) {
if (!this._active && !this._isEmptyMenu()) {
this._flagLayoutUpdateRequired = true;
return;
}

this._requestLayoutUpdate();
} else if (signal === 'ItemsPropertiesUpdated') {
if (!this._active) {
if (!this._active && !this._isEmptyMenu()) {
this._flagItemsUpdateRequired = true;
return;
}
Expand Down