Skip to content

Conversation

@weining-li
Copy link
Contributor

Modified some css code to allow the Admin Widgets and Admin Users to be reachable by tabbing.

#53

Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sublinks can be tabbed to but are not visible unless the parent heading has focus - see suggestion below.

I'm not sure how I feel about sublinks being present on the page at all times, since they can be moused over even when not visible. However, you could use pointer-events to disable mouse events while the sublinks are hidden, then re-enable them when they're visible. Again, see suggestions below.

@FrenjaminBanklin FrenjaminBanklin changed the base branch from master to dev/2.1.0 July 19, 2019 16:05
Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is mostly working, though now that the collaboration dialog is reacting to the Enter key a new bug is coming up. It looks like the ngEnter directive is firing twice when the Enter key is pressed on buttons - since it's reacting to both keydown and keypress events.

This is normally not an issue, but since the 'Save' button in the collaboration dialog is now sending two calls with the same information instead of one, the backend is failing on the second call - since permissions to a widget must be unique, the second call is reacting in a failure. You can reproduce this easily by tabbing to the collaboration window's 'Save' button and pressing 'Enter'.

This should be pretty easy to avoid by adjusting the directive to only listen to keydown or keypress, but not both. keypress is probably adequate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants