Skip to content

Conversation

@stellaprins
Copy link
Collaborator

@stellaprins stellaprins commented Jul 16, 2025

What does this PR do?
This PR adds support for plotting line elements in the plotArray method of the kWaveArray class. Previously, attempting to plot a line element resulted in an error due to unsupported element type. The new code handles the 'line' case.

It can be tested with the following code:

karray=kWaveArray;
karray.addLineElement([1,1,1], [2,3,4]);
karray.plotArray;

This should result in the following Figure:
Figure_1

I also checked plotting for other accepted dimensional inputs for start_point and end_point, i.e. 1D: [x], 2D: [x, y].

Fixes #4 Bug: kWaveArray support for plotting line elements 🐛

Notes
Note that the CI is working! 🎉

@stellaprins stellaprins marked this pull request as ready for review July 16, 2025 12:58
@stellaprins stellaprins requested a review from bencox July 16, 2025 12:58
@stellaprins stellaprins self-assigned this Jul 16, 2025
@stellaprins stellaprins deleted the sp/4-bug_line_elements branch July 18, 2025 14:18
@stellaprins stellaprins restored the sp/4-bug_line_elements branch July 18, 2025 14:19
@stellaprins
Copy link
Collaborator Author

Oops! I accidentally deleted this branch while cleaning up some old and merged ones, opening it again.

@stellaprins stellaprins reopened this Jul 18, 2025
@bencox bencox merged commit 1b78ef4 into ucl-bug:main Jul 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: kWaveArray support for plotting line elements

2 participants