Bug fix: alpha_power input checking #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`medium.alpha_coeff` was incorrectly checked instead of `medium.alpha_power`. Thanks to @cldonovan for spotting the issue and suggesting the correct fix!
bencox
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #15 Bug: input checking gives misleading message 🐛
medium.alpha_coeffwas incorrectly checked inkspaceFirstOrder_inputCheckinginstead ofmedium.alpha_power, as pointed out by @cldonovan.After the bug fix, the correct error message was displayed when
medium.alpha_coeffwas set to an invalid value, verified by running an example with alteredmedium.alpha_coeffboth before and after the fix.Thanks to @cldonovan for spotting the issue and suggesting the correct fix! 🚀✨