Add CI for regression tests #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns/k-wave into sp/improve_CI_output_2
For testing the workflow
…sult display functions
(these were commented out for testing purposes)
…egression_tests
bencox
approved these changes
Jul 30, 2025
Collaborator
bencox
left a comment
bencox
left a comment
There was a problem hiding this comment.
Looks very useful, thank you.
I realised that when you open the CI output (if it has failed) it directs you to the end of the output, so it makes more sense to put this information at the end after all
Collaborator
Author
|
Thanks @bencox! I made one last tweak. I realised the CI output opens at the bottom when it fails, so it actually makes more sense to put the most important info (N failed / passed & failed tests) at the end. I’ll merge once I’ve confirmed the CI output looks right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolves #23 by running the regression tests in the GitHub Actions workflow.
Generalises
runUnitTestsfunctions for reuse with regression tests.runUnitTests_show_results->show_test_resultsrunUnitTests_create_artifact->save_artifactRuns regression and unit tests in the same workflow to create a clear overview
unit_tests.yml->run_tests.ymlSee the new CI output here.
Linked issues
#9 #23
Notes
Adding both the unit and regression tests to the same
run_tests.ymlmakes theymlfile a little bit more unwieldy but results in a much nicer CI output compared to seperating them. I tried to avoid some of the repetition in theymlfile with the use of anchors but decided the code was clearer as it was without anchors.