dataquest -> lindat sync #62
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matus Kasak <[email protected]>
* FIX: Add quotes to curl download command
* Added rendering namespace when client side * Added SSR excluded path into config file
…ce#956) * Refactored en.json5 structure by upstream * Refactored cs.json5 structure by upstream --------- Co-authored-by: Matus Kasak <[email protected]>
Co-authored-by: Matus Kasak <[email protected]>
Co-authored-by: Matus Kasak <[email protected]>
* added missing prefix * security: harden namespace handling in legacy bitstream redirect guard * harden legacy bitstream redirect namespace * removed security control * modified curl, download bitstreams based on the name as separeated api calling * remove -k argument from curl * removed debug console
…ce dataquest/dspace-angular and the full image will go into dataquest/dspace-angular-dev
Co-authored-by: Copilot <[email protected]>
…image_size minify docker image size
Co-authored-by: Matus Kasak <[email protected]>
* Run script and syncing en and cs messages * Syncing again the translations and updated a few more * Fixing mistake in translation * Corrected word attributy to atributy * Fixed english messages, and czech related to them * Implemented change in word atributy --------- Co-authored-by: Matus Kasak <[email protected]> Co-authored-by: Juraj Roka <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…ui.json not the /app/docker/dspace-ui.json (DSpace#1060)
filter config.json before exposing it
Co-authored-by: Matus Kasak <[email protected]>
* Added check for running script after updating i18n messages * Updated template and added check for manual testing * Added link to test scenarios * Added check to copilot review --------- Co-authored-by: Matus Kasak <[email protected]>
* Add cache config to public config to prevent frontend errors * Full cache expose in config * Trying to expose whole rest property * Trying to expose rest.sll property * Trying to expose cache.autoSync * Trying to expose rest.ssrBaseUrl * Commented out the integration test which used exposed config file --------- Co-authored-by: milanmajchrak <[email protected]>
* VSB-TUO/Display total downloads for each item (DSpace#961) * Added new feature for downloads of item's bitstreams * Fixed Copilot's suggestions: any type & redundant property access pattern * VSB-TUO/Make item view - Total Downloads - configurable (DSpace#996) * Implemented configurable showing of component * refactor: provide UsageReportDataService as singleton to avoid duplicate instances
* Changed method of rendering table with versions to toggle dropdown * Refactor by Copilot's suggestions * Added version history as item-field * Divided Admin view and Anonymous/User view of version history and changed UI of item-versions-field * Added clarin-item-versions-field to publication template, added spacing between icon and heading * Added keyboard event handling (enter) * Edit of manual Observable creation * clarin-item-versions-field extends item-versions to avoid duplicate code * reverted new admin view of item-versions history to usual look * Usage of more common way for checking if is Admin * removed duplicate interface * change to duplicate interfaces, but avoiding any type * implementation of more effective method concating strings * Added documentation for the need of protected access modifiers * Fixed documentation to valid JSDoc tag, prevention for not initializing this.isAdmin$ * Changed isAdmin warpper to section * added calc() to scss * Fix of uninitialized isAdmin handling * Optimization of hasDraftVersion logic - exposing it as an observable * Fixed logic checking value of this.hasDraftVersion$ * Reverted css, removed unclear typing from new methods * Fixed versionItem type handling * Changed expand/collapse text to translation keys * fix: avoid array mutation by creating copy before reversing version list * perf: optimize version history by pre-computing workspace/workflow IDs and using trackBy
- package.json - "@types/d3-dispatch": "3.0.6" -> 3.0.7 is not working with the used ts version - "ngx-mask": "~13.1.7" -> 13.2.2 was not working - epic-handle-table.component.html - pageInfoState was removed between 7.6.1 and 7.6.5 - lazy-theme.module.ts - missing comma
unit tests werer not working
The test were failing because https://angular.io/errors/NG0203 providing the missing param (APP_CONFIG) was one option; running from within `TestBed.runInInjectionContext` probably another one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for next release; this contains the following changes:
Upgrade CLARIN-DSpace to v7.6.5. (dataquest-dev#941)
UFAL/The dspace.log file wasn't created in the container (dataquest-dev#943)
UFAL/Update baseHref in the index.html for correct SSR fetching (dataquest-dev#944)
Ufal/Fix rendering client side namespace (dataquest-dev#945)
Run import action with actual admin credentials
Try to make /dspace/var/oai/requests immutable to replicate an error
Allow reindexing Solr when an Item is created.
ZCU-DATA/added to trigger ui tests (dataquest-dev#934)
UFAL/Sync translation messages and their structure with vanilla (dataquest-dev#956)
Removed duplicity and enabled playwright tests (dataquest-dev#982)
Replacing admin and user (dataquest-dev#984)
Skipping customer/uk branch in triggering playwright tests (dataquest-dev#1049)
UFAL/Synchronization of en.json5 and cs.json5 (dataquest-dev#1037)
Update .github/workflows/docker.yml
Merge pull request dataquest-dev#1036 from dataquest-dev/ufal/minify_docker_image_size
FIX: Add quotes to curl download command (dataquest-dev#939)
Merge remote-tracking branch 'dataquest-dev/dtq-dev' into HEAD
UFAL/download-bitstreams-as-separated-api-calling (dataquest-dev#969)
both dockerfiles are now pushed to docker hub, the smaller will replace dataquest/dspace-angular and the full image will go into dataquest/dspace-angular-dev
Using a conditional spread
missing comma
Merge pull request dataquest-dev#1059 from dataquest-dev/filter_exposed_config
frontend will get filtered version of config.json without sensitive information
fix auth property exposure
access to nested properties could cause runtime errors...
even more specific config filtering
UFAL/Add cache config to public config (dataquest-dev#1069)
UFAL/Cherrypick Total Downloads (dataquest-dev#998)
UFAL/Item versioning table view edit (dataquest-dev#999)
UFAL/Added space to title (dataquest-dev#1070)
UFAL/Updated PR template (dataquest-dev#1056)
We used *.dist dockerfile and the
dspace-ui.jsonis on /app/dspace-ui.json not the /app/docker/dspace-ui.json (dataquest-dev#1060)