-
Notifications
You must be signed in to change notification settings - Fork 79
feat: Migrate to uv from pipenv #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d3d0cd3 to
3d3fc72
Compare
|
Thank you so much for this. I was plannign to handle the CI pipeline first, then come to this but that order is not a strict requirement. |
pyproject.toml
Outdated
| "Programming Language :: Python :: 3.8", | ||
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", | ||
| "Programming Language :: Python :: 3.13", | ||
| "Programming Language :: Python :: 3.14", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list doesn't match the versions from #226 The project is in a transition period, and we are not testing againist any Python version yet but this is the closest thing we have to "supported Python list".
pyproject.toml
Outdated
| "Intended Audience :: Developers", | ||
| "Operating System :: OS Independent", | ||
| "Programming Language :: Python :: 3 :: Only", | ||
| "Programming Language :: Python :: 3.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also recommend updating the existing classifiers in setup.py file with supported versions before changing the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ulgens OK
|
I also think we should drop support for Python 3.8 and Python 3.9 for this package, as they are already EOL before this uv PR is merged. I checked the test cases and noticed that they use the pytz package and it is also not available by default (Third party library). Since Python 3.9+ introduced the zoneinfo library, we can replace pytz with it. Any thoughts, @ulgens? |
I was trying to keep an overlap for supported Django - Python versions between the latest release and the next one, so that the update process will be less painful for the users but I just removed I'm okay with adding pytz depedency for a temporary period. |
👍 |
3d3fc72 to
895342f
Compare
|
Update:
|
|
Thanks for the update. About pytz, is it useful now? Were you able to run tests locally, or does the project itself depend on it? If not, I'd recommend adding the pytz where it's useful. Do we still need |
Currently working on it (test cases) |
|
We don't need this file anymore, also it's too complex. |
Description
Migrated from Pipenv to uv
Added support for pyproject.toml with uv
Removed files:
setup.pysetup.cfgMANIFEST.inPipfilePipfile.lockuv buildorpipx run buildSource Distribution
Wheel Distribution