Skip to content

Conversation

@DhavalGojiya
Copy link

@DhavalGojiya DhavalGojiya commented Jan 5, 2026

Description

Migrated from Pipenv to uv

Added support for pyproject.toml with uv

Removed files:

setup.py
setup.cfg
MANIFEST.in
Pipfile
Pipfile.lock


uv build or pipx run build

Source Distribution

Source distribution build output

Wheel Distribution

Wheel distribution build output

@DhavalGojiya DhavalGojiya force-pushed the feat/migrate-to-uv branch 2 times, most recently from d3d0cd3 to 3d3fc72 Compare January 5, 2026 15:12
@ulgens
Copy link
Owner

ulgens commented Jan 6, 2026

Thank you so much for this. I was plannign to handle the CI pipeline first, then come to this but that order is not a strict requirement.

pyproject.toml Outdated
Comment on lines 20 to 26
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: 3.14",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list doesn't match the versions from #226 The project is in a transition period, and we are not testing againist any Python version yet but this is the closest thing we have to "supported Python list".

pyproject.toml Outdated
"Intended Audience :: Developers",
"Operating System :: OS Independent",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3.8",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also recommend updating the existing classifiers in setup.py file with supported versions before changing the list.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ulgens OK

@DhavalGojiya
Copy link
Author

I also think we should drop support for Python 3.8 and Python 3.9 for this package, as they are already EOL before this uv PR is merged.

I checked the test cases and noticed that they use the pytz package and it is also not available by default (Third party library).

Since Python 3.9+ introduced the zoneinfo library, we can replace pytz with it.
We can proceed step by step.

Any thoughts, @ulgens?

@ulgens
Copy link
Owner

ulgens commented Jan 7, 2026

I also think we should drop support for Python 3.8 and Python 3.9 for this package, as they are already EOL before this uv PR is merged.

I was trying to keep an overlap for supported Django - Python versions between the latest release and the next one, so that the update process will be less painful for the users but I just removed django<4.2 yesterday (the latest release was supporting <=4.1) to have a better experience with the CI testing adoption. Removing 3.8 and 3.9 is definitely possible, but I don't want to prioritize it if it's not absolutely necessary.

I'm okay with adding pytz depedency for a temporary period.

@DhavalGojiya
Copy link
Author

I also think we should drop support for Python 3.8 and Python 3.9 for this package, as they are already EOL before this uv PR is merged.

I was trying to keep an overlap for supported Django - Python versions between the latest release and the next one, so that the update process will be less painful for the users but I just removed django<4.2 yesterday (the latest release was supporting <=4.1) to have a better experience with the CI testing adoption. Removing 3.8 and 3.9 is definitely possible, but I don't want to prioritize it if it's not absolutely necessary.

I'm okay with adding pytz depedency for a temporary period.

👍

@DhavalGojiya
Copy link
Author

DhavalGojiya commented Jan 8, 2026

Update:

  • Added pytz to the dev dependencies temporarily
  • Rebased successfully with the latest project state
  • Updated classifiers

@ulgens
Copy link
Owner

ulgens commented Jan 8, 2026

Thanks for the update.

About pytz, is it useful now? Were you able to run tests locally, or does the project itself depend on it? If not, I'd recommend adding the pytz where it's useful.

Do we still need ez_setup.py file?

@DhavalGojiya
Copy link
Author

Thanks for the update.

About pytz, is it useful now? Were you able to run tests locally, or does the project itself depend on it? If not, I'd recommend adding the pytz where it's useful.

Do we still need ez_setup.py file?

Currently working on it (test cases)

@DhavalGojiya
Copy link
Author

ez_setup.py

We don't need this file anymore, also it's too complex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants