Skip to content

Partial fix for Throughput Shaping Timer #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pbaykalov wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Partial fix for Throughput Shaping Timer #558

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
930029e
add requested comment
pbaykalov Dec 15, 2022
c4580a8
correct handling or RPS<1
pbaykalov Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions plugins/tst/src/main/java/kg/apc/jmeter/timers/VariableThroughputTimer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,14 @@ private int getDelay(long millisSinceLastSecond) {
if (log.isDebugEnabled()) {
log.debug("Calculating {} {} {}", millisSinceLastSecond, cntSent * msecPerReq, cntSent);
}
if (millisSinceLastSecond < (cntSent * msecPerReq)) {
// TODO : Explain this for other maintainers


if (millisSinceLastSecond < (cntSent * msecPerReq) || msecPerReq > 1000) {
//this code allows for very big number of threads to be fired each second (at most 1 divided by how much time "delay" runs because it's synchronized)
//each second has number of requests to fire
//this condition evaluates to true if threads have been firing (executing "sample" and then executing "delay") quickly enough since the second started
//otherwise next thread should be fired instantly

// cntDelayed + 1 : Current threads waiting + this thread
return (int) (1 + 1000.0 * (cntDelayed + 1) / rps);
}
Expand Down