fix: Prevent invalid "/**/*" Include path when DesktopProjectFolder is empty #21712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bute Co-authored-by: MartinZikmund <[email protected]>
Copilot
AI
changed the title
[WIP] Fix build error due to invalid Include attribute in targets file
fix: Prevent invalid "/**/*" Include path when DesktopProjectFolder is empty
Oct 30, 2025
Copilot finished work on behalf of
MartinZikmund
October 30, 2025 10:17
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21712/wasm-skia-net9/index.html |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21712/docs/index.html |
Youssef1313
reviewed
Oct 30, 2025
|
|
||
| <ItemGroup Condition="$(PlatformsProjectFolder) != '' and Exists($(PlatformsProjectFolder))"> | ||
| <_TargetPlatformFiles Include="$(DesktopProjectFolder)/**/*" Condition="Exists('$(DesktopProjectFolder)')"/> | ||
| <_TargetPlatformFiles Include="$(DesktopProjectFolder)/**/*" Condition="'$(DesktopProjectFolder)' != '' AND Exists('$(DesktopProjectFolder)')"/> |
Member
There was a problem hiding this comment.
This is unlikely to fix the linked issue.
Contributor
|
The build 180279 found UI Test snapshots differences: Details
|
Contributor
|
Was it fixed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSBuild validates Include attribute syntax before evaluating conditions. When
DesktopProjectFolderis empty (Desktop folder doesn't exist), the Include path becomes/**/*, causing build failures.Changes
Modified
Uno.SingleProject.Desktop.targetsline 33:Added empty-string check to prevent evaluation when folder doesn't exist. Aligns with existing pattern used for platform folder handling in
Uno.Common.targetslines 106-121.Context
Unlike other platform folders (Android, iOS, MacCatalyst) which always have default values,
DesktopProjectFolderis only set when the folder exists, making it the only platform folder that can be empty.Related: dotnet/msbuild#9351
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
aka.mscurl -I -sSL --retry 5 --retry-delay 2 --connect-timeout 15 REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
The value "/**/*" of the "Include" attribute in element <ItemGroup> in file .nuget\packages\uno.sdk\5.2.161\targets\Uno.SingleProject.Desktop.targets#17297💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.