fix(trimmer): Fix IL3050 warnings around Enum use #21746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform/wasm 🌐
jonpryor
force-pushed
the
dev/jonpryor/jonp-fix-IL3050-Enum.GetValues
branch
from
be93926 to
f2b57a4
Compare
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21746/docs/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21746/wasm-skia-net9/index.html |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21746/docs/index.html |
When building `src/Uno.UI` with trimmer warnings enabled (and turned up to 11): dotnet build src/Uno.UI/Uno.UI.Skia.csproj -bl \ -p:TrimmerSingleWarn=false -p:_ExtraTrimmerArgs=--verbose -p:IsTrimmable=true -p:IsAotCompatible=true One of the warnings is: src/Uno.UI/UI/Xaml/Internal/InputManager.Pointers.ManagedDirectManip.cs(365,42): error IL3050: Using member 'System.Enum.GetValues(Type)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. It might not be possible to create an array of the enum type at runtime. Use the GetValues<TEnum> overload or the GetValuesAsUnderlyingType method instead. Replace use of `System.Enum` methods which take a `Type` parameter with their generic method overload: * `Enum.GetName(typeof(T), v)` becomes `Enum.GetName((T)v)` * `Enum.GetNames(typeof(T))` becomes `Enum.GetNames<T>()` * `Enum.GetValues(typeof(T))` becomes `Enum.GetValues<T>()` * `Enum.IsDefined(typeof(T), v)` becomes `Enum.IsDefined((T)v)` * `Enum.Parse(typeof(T), v)` becomes `Enum.Parse<T>(v)` This fixes the IL3050 warnings.
jonpryor
force-pushed
the
dev/jonpryor/jonp-fix-IL3050-Enum.GetValues
branch
from
f2b57a4 to
29f5236
Compare
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21746/docs/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21746/wasm-skia-net9/index.html |
Contributor
|
|
Contributor
|
The build 180925 found UI Test snapshots differences: Details
|
ramezgerges
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building
src/Uno.UIwith trimmer warnings enabled (and turned up to 11):One of the warnings is:
Replace use of
System.Enummethods which take aTypeparameter with their generic method overload:Enum.GetName(typeof(T), v)becomesEnum.GetNames<T>(v)Enum.GetNames(typeof(T))becomesEnum.GetNames<T>()Enum.GetValues(typeof(T))becomesEnum.GetValues<T>()Enum.IsDefined(typeof(T), v)becomesEnum.IsDefined<T>(v)Enum.Parse(typeof(T), v)becomesEnum.Parse<T>(v)This fixes the IL3050 warnings.
GitHub Issue: closes #
PR Type:
What is the current behavior? 🤔
What is the new behavior? 🚀
PR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️