fix(Menu): correct emitted event types to match runtime behavior #2119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
kricsleo
changed the title
|
@kricsleo I rmb those 2 emit was designed to be use internally only. Exposing it might leads to unintended behavior if user should choose to |
|
So you're suggesting we remove the runtime behavior as well as the types? 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2118
The
entryFocus/openAutoFocusevents were removed in PR https://github.com/unovue/reka-ui/pull/665/files#diff-8c2f58c8ccca9f2d06c2bde73a649a7b23180c696e73ede751e31c6623b5254dR7. I'm not sure why, but this caused the event types to mismatch the runtime behavior (these events are still emitted). So, I think it's better to revert this type omitting change.