fix: make Icon work when used in Action (#8303) (CP: 23.7)
#8327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoCardoso
force-pushed
the
cp/23.7/8285
branch
from
ad9acfb to
59e823e
Compare
* fix: make `Icon` work when used in `Action` This change fixes the issue when adding an icon to an action in the context menu in Spreadsheet. To make it work, the following modifications were made: - Add the `Icon` instance passed to the `Action(String, Icon)` as a virtual child to `Spreadsheet` - Passes the node id of the element to the client side to be fetched - Modifies the `SpreadsheetAction` class to overwrite the `getHTML` method in order to add a container for the icon, in case the action has one - Attaches the icon instance to the container - Creates an event to be dispached when the context menu is closed - Listens to the event to make sure that any `Icon` instance is safely removed from the client to avoid memory leaks Fixes #8288
DiegoCardoso
force-pushed
the
cp/23.7/8303
branch
from
3bc6629 to
124b10a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CP from #8303 to 23.7
Depends on #8326