Add Timeouts methods to Client #1096
Draft
+136
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current Timeout/Deadline methods starting a new goroutine is something most users don't seem to understand. They also don't get the performance implications of using this vs setting a ReadTimeout/WriteTimeout. Setting A ReadTimeout/WriteTimeout is always better. Maybe we shoud deprecate the old methods.
|
@kirillDanshin @valyala what do you think of this? |
erikdubbelboer
force-pushed
the
master
branch
from
18bceed to
0ad54a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Timeout/Deadline methods starting a new goroutine is
something most users don't seem to understand. They also don't get the
performance implications of using this vs setting a
ReadTimeout/WriteTimeout.
Setting A ReadTimeout/WriteTimeout is always better. Maybe we shoud
deprecate the old methods.