-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: do not error when not enabled during suspense #4156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| 'use client' | ||
|
|
||
| import { Suspense, useReducer } from 'react' | ||
| import useSWR from 'swr' | ||
|
|
||
| const fetcher = async (key: string) => { | ||
| // Add a small delay to simulate network request | ||
| await new Promise(resolve => setTimeout(resolve, 100)) | ||
| return 'SWR' | ||
| } | ||
|
|
||
| const Section = ({ trigger }: { trigger: boolean }) => { | ||
| const { data } = useSWR(trigger ? 'test-key' : undefined, fetcher, { | ||
| suspense: true | ||
| }) | ||
| return <div>{data || 'empty'}</div> | ||
| } | ||
|
|
||
| export default function Page() { | ||
| const [trigger, toggle] = useReducer(x => !x, false) | ||
|
|
||
| return ( | ||
| <div> | ||
| <button onClick={toggle}>toggle</button> | ||
| <Suspense fallback={<div>fallback</div>}> | ||
| <Section trigger={trigger} /> | ||
| </Suspense> | ||
| </div> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| /* eslint-disable testing-library/prefer-screen-queries */ | ||
| import { test, expect } from '@playwright/test' | ||
|
|
||
| test.describe('suspense with undefined key', () => { | ||
| test('should render correctly when key is undefined', async ({ page }) => { | ||
| await page.goto('./suspense-undefined-key', { waitUntil: 'commit' }) | ||
|
|
||
| // Should show content for undefined key (not suspense) | ||
| await expect(page.getByText('empty')).toBeVisible() | ||
|
|
||
| // Click toggle to enable key | ||
| await page.getByRole('button', { name: 'toggle' }).click() | ||
|
|
||
| // Should show loading fallback when key becomes defined | ||
| await expect(page.getByText('fallback')).toBeVisible() | ||
|
|
||
| // Should eventually show the fetched data | ||
| await expect(page.getByText('SWR')).toBeVisible() | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.