fix: await async onSuccess/onError callbacks to prevent unhandled rej… #4177
+16
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where useSWRMutation does not await async onSuccess or onError callbacks.
Previously, when developers provided an async callback (for example, revalidating data with mutate(key)), it was executed in parallel with the return of trigger(), leading to race conditions and unhandled promise rejections.
Now, async callbacks are awaited safely, preventing unhandled rejections while maintaining backward compatibility.
Example
Fix
Related Issue: #4171