[D-13736]: Forcechange flag to edit a user via CLI is not working correctly #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rectly 1. Set default value for force change as 1. 2. Changed the condition in getattr to check None instead of just checking if the param has value in it. The reason why i changed to None is when an integer value is checked and if the integer has a value 0 for the param, the if evaluates false and the the param is not even considered while executing the CLI
aishwarya2392
requested review from
bvikrammahadev,
indumathiValliappan,
klmarsh4,
manojss and
vetrivelv
vetrivelv
approved these changes
May 30, 2019
klmarsh4
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason why i changed to None is when an integer value is checked and if the integer has a value 0 for the param, the if evaluates false
and the the param is not even considered while executing the CLI