Skip to content

Fix CDP browser detection #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vgalin wants to merge 1 commit into from
Closed

Fix CDP browser detection #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion html2image/html2image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,10 @@ def __init__(

browser_class = browser_map[browser.lower()]

if isinstance(browser_class, CDPBrowser):
# browser_map stores classes, not instances. Use ``issubclass`` to
# check if the selected browser class supports the Chrome DevTools
# Protocol and therefore expects the ``cdp_port`` argument.
if issubclass(browser_class, CDPBrowser):
self.browser = browser_class(
executable=browser_executable,
flags=custom_flags,
Expand Down
Loading