Signal sigusr1 to viam server on stop #185
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjirewis
reviewed
Jan 21, 2026
subsystems/viamserver/viamserver.go
Outdated
| s.logger.Infof("Stopping %s", SubsysName) | ||
|
|
||
| // Send SIGUSR1 first to request stack trace dump before shutdown. | ||
| if err := utils.SignalForStackTrace(s.cmd.Process.Pid); err != nil { |
Member
There was a problem hiding this comment.
I realize this PR is in draft, but just a note that we'll only want to send SIGUSR1 if a restart of the part was requested from app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.