[RSDK-12271] Check restart_allowed in agent on Windows #188
+2
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RSDK-12271 Check restart_allowed in agent on Windows
restart_allowedofrestart_statusendpoint ofviam-serverTesting
agentrepo, pulled in branchgo build -o viam-agent.exe ./cmd/viam-agentand createdC:/etc/directory with brand new machine'sviam.json./viam-agent.exe"maintenance_allowed key b is not a bool value"but this Slack message seems to suggest that anything that isn't explicitly "true" is interpreted as false, so I think this is fine for testing purposes)viam_server_envsetting with a random env var/value to trigger a restart, and I observed the logviam-server has NOT allowed a restart; will NOT restartsuggesting agent on Windows is checking and respectingrestart_allowedI also tested that by undoinging these changes,
restart_allowedwas no longer respected andviam-serverrestarts anyway.