Skip to content

Conversation

@zbigg
Copy link
Contributor

@zbigg zbigg commented Nov 19, 2025

Summary:

  • fix invalid cross-module import in @deck.gl-community/editable-layers

Fixes, fegression from #333

This fix interesting issue with tsc jumping from "{moduleA}/dist/..." to "{moduleB}/src" when checking types.

Note, that currently distributed node_modules/@deck.gl-community/editable-layers/dist/lib/layers/segments-layer.d.ts for reads like this:

import { PathMarkerLayer } from "../../../../layers/src/path-marker-layer/path-marker-layer.js";

That means, it imports not from "official types" of @deck.gl-community/layers which live in dist/..., but does "self-path-traversal-attack" and reaches to 'src' folder of this package.

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for testing and fixing!
This may have been done when asking LLM to move the layers.
We may want to add some cross-import rules to AGENTS.md

@ibgreen ibgreen merged commit 5c56bc1 into visgl:master Nov 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants