Fastrand version bump to be compatible with Graphite #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'll probably add additional feature flag to the cli crate. |
Author
Should be fine to rely on the git dep for now. The feature flag sounds like the right solution. Thanks! |
Member
|
bumped, please check 8acb6bd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello - I am a contributor to Graphite and I am working on a vectorization feature powered by vtracer.
I am in the process of adding support for vtracer to Graphite presently. I discovered that we have trouble compiling to wasm with the current vtracer crate due to a limitation in regards to the version of fastrand + a feature flag it requires.
I have created the minimum possible change set to vtracer that allows it to work with Graphite. These changes simply bump the version number and add the feature flag required we need for graphite. I recognize we may need to add a new feature flag to vtracer to support fastrand's "js" feature flag as opposed to defaulting it to on. I wanted to leave that choice up to you, the original maintainers.
Much respect, appreciate and admiration. Oliver @ Graphite
Here is a very early screenshot of the vectorization "working" within Graphite to help motivate these changes.
