Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Run Tests in my project every push on GitHub
name: Run Tests in my project every push / pr on GitHub

on: [push, pull_request]

Expand Down
7 changes: 6 additions & 1 deletion lib/controllers/ExplorerController.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ class ExplorerController{
const explorers = Reader.readJsonFile("explorers.json");
return ExplorerService.getAmountOfExplorersByMission(explorers, mission);
}

static getExplorersByStack(stack){
const explorers = Reader.readJsonFile("explorers.json");
return ExplorerService.filterByStack(explorers, stack);
}
}

module.exports = ExplorerController;
module.exports = ExplorerController;
6 changes: 6 additions & 0 deletions lib/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ app.get("/v1/fizzbuzz/:score", (request, response) => {
response.json({score: score, trick: fizzbuzzTrick});
});

app.get("/v1/explorers/stack/:stack", (request, response) => {
const stack = request.params.stack;
const explorersStack = ExplorerController.getExplorersByStack(stack);
response.json(explorersStack);
});

app.listen(port, () => {
console.log(`FizzBuzz API in localhost:${port}`);
});
Expand Down
7 changes: 6 additions & 1 deletion lib/services/ExplorerService.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ class ExplorerService {
return explorersUsernames;
}

static filterByStack(explorers, stack){
const explorersByStack = explorers.filter((explorer) => explorer.stacks.includes(stack));
return explorersByStack;
}

}

module.exports = ExplorerService;
module.exports = ExplorerService;
7,180 changes: 5,443 additions & 1,737 deletions package-lock.json

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "",
"main": "index.js",
"scripts": {
"test": "node ./node_modules/.bin/jest",
"test": "node ./node_modules/jest/bin/jest.js",
"linter": "node ./node_modules/eslint/bin/eslint.js",
"linter-fix": "node ./node_modules/eslint/bin/eslint.js . --fix",
"server": "node ./lib/server.js"
Expand All @@ -14,9 +14,9 @@
"license": "ISC",
"devDependencies": {
"eslint": "^8.14.0",
"jest": "^27.5.1"
"jest": "^26.0.0"
},
"dependencies": {
"express": "^4.17.3"
"express": "^4.18.1"
}
}
11 changes: 11 additions & 0 deletions test/controllers/ExplorerController.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
const ExplorerController = require("./../../lib/controllers/ExplorerController");

describe("Test suite para ExplorerController", () => {

test("Requerimiento 1: Obtener los explorers que tengan un stack determinado", () => {

const explorersJavascript = ExplorerController.getExplorersByStack("javascript");

expect(explorersJavascript.length).toBe(11);
});
});
7 changes: 7 additions & 0 deletions test/services/ExplorerService.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,11 @@ describe("Tests para ExplorerService", () => {
expect(explorersInNode.length).toBe(1);
});

test("Requerimiento 2: Obtener los explorers que tengan un stack", () => {
const explorers = [{mission: "node", stacks: ["node", "javascript", "css"]}];
const explorersJavascript = ExplorerService.filterByStack(explorers, "javascript");

expect(explorersJavascript.length).toBe(1);
});

});