-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
veb: gzip support for StaticHandler #25758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
01439a6 to
4694483
Compare
|
@spytheman Thanks for the review. I've implemented fixes in dedicated commits to make it easier for you to see changes, I'll squash when it will be ok for you.
Let me know if you see any better way to test read-only for windows (I don't have a Windows system here to check) |
|
@davlgd thank you 🙇🏻 .
There is no need to squash them manually, the repo is set to squash changes automatically before they are merged in master. |
Skipping the readonly test on windows (as you did) is perfectly fine and acceptable - most people will not run web servers on that OS, and will probably not have a readonly filesystem either. |
Co-Authored-By: Delyan Angelov <[email protected]>
4694483 to
9884cdd
Compare
* master: cgen: fix dump(ptr_to_fixed_array_value) - it now returns the argument directly (thanks @tankf33der) (vlang#25764) type_resolver: clear option flag if present in comptime $for (fix vlang#25761) (vlang#25763) db.sqlite: update windows version to https://sqlite.org/2025/sqlite-amalgamation-3510000.zip (vlang#25766) builder,pref: add `-file-list` support (implement feature vlang#25707) (vlang#25749) transformer: transform ArrayInit into a function call for C and native backends (part 1) doc: cleanup grammar issues in doc/docs.md parser: allow using `a`, `b` and `it` as var names, when using the builtin array methods (fix vlang#25729) (vlang#25755) v.builder: improve diagnostic information for a failed build_thirdparty_obj_file veb: fix gzip middleware decode/encode (fix vlang#20865) (fix vlang#25753) (vlang#25754) strconv: fix handling of subnormal numbers like `'1.23e-308'.f64()` (fix vlang#25751) (vlang#25752) crypto.blake2b,crypto.blake2s: add `@[direct_array_access]` to hot functions (vlang#25750)
spytheman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work @davlgd .
Thank you very much 🙇🏻 .
This PR removes the "skip gzip if static file" behavior by adding two features:
.gzvariantI've added tests and a documentation example for this. Feel free to tell me if you need some adjusments or a different behavior
Fix #20859