Skip to content

Conversation

@stzoozz
Copy link
Contributor

@stzoozz stzoozz commented Oct 30, 2025

SUMMARY:
Replace hardcoded HUGGINGFACE_CO_URL_HOME with HfApi().endpoint to enable custom HuggingFace endpoint configuration via HF_ENDPOINT environment variable. (Fixed #1967)

TEST PLAN:
Tested with custom endpoint (HF_ENDPOINT=https://hf-mirror.com): Uses mirror site.

Any feedback or suggestions for improvement are welcome!

Replace hardcoded HUGGINGFACE_CO_URL_HOME with HfApi().endpoint
to enable custom HuggingFace endpoint configuration via HF_ENDPOINT
environment variable.
@github-actions
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @stzoozz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where model recipe downloads were hardcoded to the default HuggingFace endpoint. By leveraging the HfApi client, the system now dynamically determines the endpoint, allowing users to specify a custom HuggingFace endpoint via the HF_ENDPOINT environment variable. This change enhances the adaptability of the system for environments requiring alternative or mirrored HuggingFace services, directly addressing issue #1967.

Highlights

  • Custom HuggingFace Endpoint Support: This pull request introduces support for configuring a custom HuggingFace endpoint for model recipe downloads, enabling greater flexibility for users operating in different network environments or with mirrored services.
  • Replaced Hardcoded URL: The previously hardcoded HUGGINGFACE_CO_URL_HOME constant has been replaced with a dynamic endpoint retrieved from HfApi().endpoint, which respects the HF_ENDPOINT environment variable.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses the issue of supporting custom Hugging Face endpoints by replacing the hardcoded URL with a dynamic endpoint from HfApi. The change is well-targeted and fixes the problem described. I have one suggestion to slightly improve the implementation by instantiating HfApi only once, which would make the code more efficient and clearer.

Copy link
Collaborator

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This looks good to me, but the gemini suggestion is slightly cleaner if you'd like to apply the suggestion

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Shuting Zhao <[email protected]>
@stzoozz
Copy link
Contributor Author

stzoozz commented Oct 30, 2025

Thanks for the contribution! This looks good to me, but the gemini suggestion is slightly cleaner if you'd like to apply the suggestion

Thanks a lot! I’ve applied the gemini suggestion.

Copy link
Collaborator

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@shanjiaz shanjiaz added the ready When a PR is ready for review label Oct 30, 2025
@brian-dellabetta brian-dellabetta enabled auto-merge (squash) October 30, 2025 19:34
@brian-dellabetta brian-dellabetta merged commit 92017b0 into vllm-project:main Oct 30, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready When a PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Respect HF_ENDPOINT instead of using HUGGINGFACE_CO_URL_HOME

4 participants