- 
                Notifications
    You must be signed in to change notification settings 
- Fork 271
Fix: Support custom HF_ENDPOINT for model recipe downloads #1982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Support custom HF_ENDPOINT for model recipe downloads #1982
Conversation
Replace hardcoded HUGGINGFACE_CO_URL_HOME with HfApi().endpoint to enable custom HuggingFace endpoint configuration via HF_ENDPOINT environment variable.
| 👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. | 
| Summary of ChangesHello @stzoozz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where model recipe downloads were hardcoded to the default HuggingFace endpoint. By leveraging the  Highlights
 Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either  
 Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a  Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly addresses the issue of supporting custom Hugging Face endpoints by replacing the hardcoded URL with a dynamic endpoint from HfApi. The change is well-targeted and fixes the problem described. I have one suggestion to slightly improve the implementation by instantiating HfApi only once, which would make the code more efficient and clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! This looks good to me, but the gemini suggestion is slightly cleaner if you'd like to apply the suggestion
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Shuting Zhao <[email protected]>
| 
 Thanks a lot! I’ve applied the gemini suggestion. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
SUMMARY:
Replace hardcoded
HUGGINGFACE_CO_URL_HOMEwithHfApi().endpoint to enable custom HuggingFace endpoint configuration viaHF_ENDPOINTenvironment variable. (Fixed #1967)TEST PLAN:
Tested with custom endpoint (
HF_ENDPOINT=https://hf-mirror.com): Uses mirror site.Any feedback or suggestions for improvement are welcome!