Skip to content

Conversation

@Jeaniowang
Copy link
Contributor

@Jeaniowang Jeaniowang commented Nov 10, 2025

What this PR does / why we need it?

[Doc] add qwen3 reranker tutorial

Does this PR introduce any user-facing change?

How was this patch tested?

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 10, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new tutorial for running the Qwen3-Reranker model on a single NPU using vLLM Ascend. The documentation is comprehensive, covering both online and offline inference. My review focuses on ensuring the correctness and clarity of the provided examples. I've identified a few issues in the example code and its corresponding output that could confuse users or prevent the code from running. Specifically, there's an error in how scores are extracted in the offline script, the example output for the offline script is incorrect, and the reference link at the end of the document is broken. Addressing these points will significantly improve the quality and usability of this tutorial.

@wangxiyuan
Copy link
Collaborator

@Jeaniowang Jeaniowang force-pushed the add_qwen3_reranker_doc branch 2 times, most recently from 824ed19 to 2e9722c Compare November 11, 2025 12:23
@Jeaniowang Jeaniowang force-pushed the add_qwen3_reranker_doc branch from 2e9722c to 4e5fb26 Compare November 11, 2025 12:31
@@ -0,0 +1,169 @@
# Single NPU (Qwen3-Reranker-8B)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please follow the doc format, take example: https://docs.vllm.ai/projects/ascend/en/latest/tutorials/DeepSeek-V3.2-Exp.html

Thanks

@Jeaniowang Jeaniowang force-pushed the add_qwen3_reranker_doc branch from 46f9a93 to 6d5db45 Compare November 16, 2025 12:29
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants