-
Notifications
You must be signed in to change notification settings - Fork 578
[Doc] add qwen3 reranker tutorial #4101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new tutorial for running the Qwen3-Reranker model on a single NPU using vLLM Ascend. The documentation is comprehensive, covering both online and offline inference. My review focuses on ensuring the correctness and clarity of the provided examples. I've identified a few issues in the example code and its corresponding output that could confuse users or prevent the code from running. Specifically, there's an error in how scores are extracted in the offline script, the example output for the offline script is incorrect, and the reference link at the end of the document is broken. Addressing these points will significantly improve the quality and usability of this tutorial.
824ed19 to
2e9722c
Compare
Signed-off-by: Jeaniowang <[email protected]>
2e9722c to
4e5fb26
Compare
| @@ -0,0 +1,169 @@ | |||
| # Single NPU (Qwen3-Reranker-8B) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please follow the doc format, take example: https://docs.vllm.ai/projects/ascend/en/latest/tutorials/DeepSeek-V3.2-Exp.html
Thanks
Signed-off-by: Jeaniowang <[email protected]>
46f9a93 to
6d5db45
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Jeaniowang <[email protected]>
Signed-off-by: Jeaniowang <[email protected]>
What this PR does / why we need it?
[Doc] add qwen3 reranker tutorial
Does this PR introduce any user-facing change?
How was this patch tested?