-
Notifications
You must be signed in to change notification settings - Fork 579
[CI] Add multi-nodes EPLB configs of DeepSeek-R1-W8A8 & Qwen3-235B-W8A8 #4144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* 'main' of https://github.com/vllm-project/vllm-ascend: fix fullgraph in ds. (vllm-project#4016)
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds multi-node EPLB test configurations for DeepSeek-R1 and Qwen3-235B models. The configurations have a few issues that need to be addressed. For the DeepSeek-R1 config, the decoder_host_index is incorrect for a two-node decoder setup, and the engine_ids are not unique across different service instances. For the Qwen3-235B config, the benchmarks section is empty, which would prevent any tests from running. I've added comments with specific suggestions to fix these issues.
tests/e2e/nightly/multi_node/config/models/DeepSeek-R1-W8A8-EPLB.yaml
Outdated
Show resolved
Hide resolved
tests/e2e/nightly/multi_node/config/models/DeepSeek-R1-W8A8-EPLB.yaml
Outdated
Show resolved
Hide resolved
tests/e2e/nightly/multi_node/config/models/DeepSeek-R1-W8A8-EPLB.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: 白永斌 <[email protected]>
…A8 (vllm-project#4144) ### What this PR does / why we need it? add DeepSeek-R1-W8A8 and Qwen3-235B-W8A8 configs in multi-nodes and EPLB scenario ### Does this PR introduce _any_ user-facing change? no - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@83f478b --------- Signed-off-by: 白永斌 <[email protected]> Co-authored-by: 白永斌 <[email protected]> Signed-off-by: luolun <[email protected]>
…A8 (vllm-project#4144) ### What this PR does / why we need it? add DeepSeek-R1-W8A8 and Qwen3-235B-W8A8 configs in multi-nodes and EPLB scenario ### Does this PR introduce _any_ user-facing change? no - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@83f478b --------- Signed-off-by: 白永斌 <[email protected]> Co-authored-by: 白永斌 <[email protected]> Signed-off-by: hwhaokun <[email protected]>
What this PR does / why we need it?
add DeepSeek-R1-W8A8 and Qwen3-235B-W8A8 configs in multi-nodes and EPLB scenario
Does this PR introduce any user-facing change?
no
How was this patch tested?