Add to store after all entities realized #951
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #951 +/- ##
==========================================
- Coverage 73.37% 73.35% -0.03%
==========================================
Files 118 118
Lines 16394 16402 +8
==========================================
+ Hits 12029 12031 +2
- Misses 3581 3586 +5
- Partials 784 785 +1
|
dantingl
previously approved these changes
Dec 11, 2024
|
/e2e |
2 similar comments
|
/e2e |
|
/e2e |
TaoZou1
force-pushed
the
refactorstore
branch
from
c49c86c to
f3961a5
Compare
yanjunz97
reviewed
Dec 16, 2024
Creating VPC need to check realized entities including vpc/lbs/ attachment. Only add those entities to store after the realization successful
TaoZou1
force-pushed
the
refactorstore
branch
from
f3961a5 to
6989fc1
Compare
|
/e2e |
1 similar comment
|
/e2e |
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating VPC need to check realized entities including vpc/lbs/ attachment.
Only add those entities to store after the realization successful