🌱Allow passing private NPM registry for quicktype install #1199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubronzhan
force-pushed
the
topic/lubron/small_improvement
branch
from
6e81615 to
e7b6d56
Compare
akutz
requested changes
Sep 26, 2025
| NPM_FLAGS := | ||
| ifneq ($(strip $(NPM_REGISTRY)),) | ||
| # Registry set (no token required) | ||
| NPM_REGISTRY := $(NPM_REGISTRY:https://%=%) |
There was a problem hiding this comment.
Is this a shell replacement? Instead of doing that, use Makefile text manipulation so what is emitted to the shell is absolute.
There was a problem hiding this comment.
I double checked, it's GNU Make's pattern substitution reference.
hack/quicktype/Makefile
Outdated
|
|
||
| # If a token is provided, add auth | ||
| ifneq ($(strip $(NPM_TOKEN)),) | ||
| NPM_FLAGS += --//$(NPM_REGISTRY):_authToken=$(NPM_TOKEN) |
There was a problem hiding this comment.
Is this a shell replacement? Instead of doing that, use Makefile text manipulation so what is emitted to the shell is absolute.
There was a problem hiding this comment.
This one doesn't do any shell replacement, just the weird npm flag
lubronzhan
force-pushed
the
topic/lubron/small_improvement
branch
from
e7b6d56 to
f6d9515
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
There might be time a private npm registry is preferred, and it might require auth. Added two new variables that could be passed when running
make generate-go/make-generate.Are there any special notes for your reviewer:
Tested:
Please add a release note if necessary: