Skip to content

Conversation

@zealenth
Copy link

References

When using progressive rendering to render reports that take more than 90s, the report hangs indefinitely.

Reproduced with a cell

import time
time.sleep(91)
print('hi')

Code changes

I tracked this down to tornadoweb/tornado#2021. In our case, the execution handler's on_message method blocks any ping/pong requests from being received, resulting in the websocket being closed after 90s

I've taken their recommend approach and offloaded the notebook handling to spawn_callback.

User-facing changes

Slow reports that previously hung will now render.

Backwards-incompatible changes

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch zealenth/voila/fix%2Fprogressive-rendering%2Fwebsocket-timeouts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant