Skip to content

Conversation

@dabelenda
Copy link
Contributor

Pull Request (PR) description

Since openldap 2.5 it is possible for slapd to use PROXY protocol listeners. This allows to get IPs of the clients through a load-balancer for logging and filtering purposes.

This PR add parameters to openldap::server to enable the usage of this feature.

This Pull Request (PR) fixes the following issues

N/A

@dabelenda dabelenda force-pushed the daa_add_proxy branch 2 times, most recently from 30ca443 to ee3338b Compare November 27, 2025 12:38
@dabelenda
Copy link
Contributor Author

The failures on Alma/Rock 8 and Debian 11 are expected, they install openldap 2.4 which does not support the feature...
I don't know how to either skip this test on these OSes or tell the test framework the failures are expected...

@dabelenda dabelenda force-pushed the daa_add_proxy branch 19 times, most recently from a0f1a38 to ad3a0ae Compare November 28, 2025 13:05
@dabelenda
Copy link
Contributor Author

@bastelfreak any idea on how I can ignore the OSes that will fail due to an old version of openldap?

I can comment out the tests, too, but I don't think this is a good idea.

@bastelfreak bastelfreak added the enhancement New feature or request label Dec 11, 2025
@bastelfreak
Copy link
Member

I'm not sure what the best behaviour is. Should the module allow you to set the parameter, even on an unsuported OS? I think it would be better if the module would raise a proper error in that case.

@dabelenda
Copy link
Contributor Author

Well, the default installation of openldap-server on these OSes does not support the parameter, but there are other packages for openldap that exist for these OSes (at least for RHEL8 I know an enterprise-supported openldap distribution), so hardcoding a failure in the manifest is weird and checking for the version of openldap is hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants