Skip to content

Conversation

@davxy
Copy link
Contributor

@davxy davxy commented Aug 26, 2025

Test Vectors for GP v0.7.0

Release candidate discussion: davxy#90

@davxy davxy marked this pull request as draft August 26, 2025 10:10
@davxy davxy marked this pull request as ready for review August 26, 2025 10:15
@emielsebastiaan
Copy link

I have one more question about your ASN.
You use fixed length integer definitions for the attributes of CoreActivityRecord & ServiceActivityRecord.
We have all of these attributes as datatype: general number serialization (GP-0.7.0-eq:C.5).
Serialization is defined here: GP-0.7.0-eq:D.2-C(13)

@davxy
Copy link
Contributor Author

davxy commented Aug 26, 2025

Yeah. The integer type there is quite arbitrary.
indeed ASN.1 is about syntax and not about encoding.
But perhaps I can write in the comments when a field should be compact encoded anyway

@emielsebastiaan
Copy link

Ok. Works for me. Thx for explaining.

@gavofyork gavofyork merged commit 5af0d27 into w3f:master Sep 9, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants